diff options
author | Fabio Berger <me@fabioberger.com> | 2017-12-07 10:52:48 +0800 |
---|---|---|
committer | Fabio Berger <me@fabioberger.com> | 2017-12-07 10:52:48 +0800 |
commit | e8495b0c7bf58cb683f70cd66a983dbf909215c0 (patch) | |
tree | 552f5da749b4e05db5c7e3893c3e9c52402fc6f5 /packages/subproviders/test/unit | |
parent | e80579a6055f75edac0fb0e948838495d6599bb5 (diff) | |
download | dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.tar dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.tar.gz dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.tar.bz2 dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.tar.lz dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.tar.xz dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.tar.zst dexon-0x-contracts-e8495b0c7bf58cb683f70cd66a983dbf909215c0.zip |
Simplify interface to signPersonalMessageAsync
Diffstat (limited to 'packages/subproviders/test/unit')
-rw-r--r-- | packages/subproviders/test/unit/ledger_subprovider_test.ts | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/packages/subproviders/test/unit/ledger_subprovider_test.ts b/packages/subproviders/test/unit/ledger_subprovider_test.ts index 95127b8d8..41c743346 100644 --- a/packages/subproviders/test/unit/ledger_subprovider_test.ts +++ b/packages/subproviders/test/unit/ledger_subprovider_test.ts @@ -71,8 +71,7 @@ describe('LedgerSubprovider', () => { }); it('signs a personal message', async () => { const data = ethUtils.bufferToHex(ethUtils.toBuffer('hello world')); - const msgParams = {data}; - const ecSignatureHex = await ledgerSubprovider.signPersonalMessageAsync(msgParams); + const ecSignatureHex = await ledgerSubprovider.signPersonalMessageAsync(data); // tslint:disable-next-line:max-line-length expect(ecSignatureHex).to.be.equal('0xa6cc284bff14b42bdf5e9286730c152be91719d478605ec46b3bebcd0ae491480652a1a7b742ceb0213d1e744316e285f41f878d8af0b8e632cbca4c279132d001'); }); @@ -80,11 +79,10 @@ describe('LedgerSubprovider', () => { describe('failure cases', () => { it('cannot open multiple simultaneous connections to the Ledger device', async () => { const data = ethUtils.bufferToHex(ethUtils.toBuffer('hello world')); - const msgParams = {data}; try { const result = await Promise.all([ ledgerSubprovider.getAccountsAsync(), - ledgerSubprovider.signPersonalMessageAsync(msgParams), + ledgerSubprovider.signPersonalMessageAsync(data), ]); throw new Error('Multiple simultaneous calls succeeded when they should have failed'); } catch (err) { @@ -157,21 +155,6 @@ describe('LedgerSubprovider', () => { }); }); describe('failure cases', () => { - it('should throw if `from` param missing when calling personal_sign', (done: DoneCallback) => { - const messageHex = ethUtils.bufferToHex(ethUtils.toBuffer('hello world')); - const payload = { - jsonrpc: '2.0', - method: 'personal_sign', - params: [messageHex], // Missing from param - id: 1, - }; - const callback = reportCallbackErrors(done)((err: Error, response: Web3.JSONRPCResponsePayload) => { - expect(err).to.not.be.a('null'); - expect(err.message).to.be.equal(LedgerSubproviderErrors.FromAddressMissingOrInvalid); - done(); - }); - provider.sendAsync(payload, callback); - }); it('should throw if `data` param not hex when calling personal_sign', (done: DoneCallback) => { const nonHexMessage = 'hello world'; const payload = { |