diff options
author | Jacob Evans <jacob@dekz.net> | 2018-04-06 12:55:03 +0800 |
---|---|---|
committer | Jacob Evans <jacob@dekz.net> | 2018-04-06 13:21:08 +0800 |
commit | 774ab8a8efa1ff5914896d9435c0362a4586c2ef (patch) | |
tree | 906e41484fce81d88b829a6d1745ca14448f3b13 /packages/subproviders/test/integration | |
parent | ea47613d901cb0e8d9543f37d7f591c91ef986c4 (diff) | |
download | dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.tar dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.tar.gz dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.tar.bz2 dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.tar.lz dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.tar.xz dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.tar.zst dexon-0x-contracts-774ab8a8efa1ff5914896d9435c0362a4586c2ef.zip |
Feedback
remove id management from testnet faucet
spread over txParams rather than modify in place
Diffstat (limited to 'packages/subproviders/test/integration')
-rw-r--r-- | packages/subproviders/test/integration/ledger_subprovider_test.ts | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/packages/subproviders/test/integration/ledger_subprovider_test.ts b/packages/subproviders/test/integration/ledger_subprovider_test.ts index 3039bd560..da858b6b3 100644 --- a/packages/subproviders/test/integration/ledger_subprovider_test.ts +++ b/packages/subproviders/test/integration/ledger_subprovider_test.ts @@ -14,6 +14,7 @@ import RpcSubprovider = require('web3-provider-engine/subproviders/rpc'); import { LedgerSubprovider } from '../../src'; import { DoneCallback, LedgerEthereumClient } from '../../src/types'; import { chaiSetup } from '../chai_setup'; +import { fixtureData } from '../utils/fixture_data'; import { reportCallbackErrors } from '../utils/report_callback_errors'; chaiSetup.configure(); @@ -25,9 +26,6 @@ async function ledgerEthereumNodeJsClientFactoryAsync(): Promise<LedgerEthereumC return ledgerEthClient; } -const TESTRPC_DERIVATION_PATH = `m/44'/60'/0'/0`; -const TEST_RPC_ACCOUNT_0 = '0x5409ed021d9299bf6814279a6a1411a7e866a631'; - describe('LedgerSubprovider', () => { let ledgerSubprovider: LedgerSubprovider; const networkId: number = 42; @@ -35,7 +33,7 @@ describe('LedgerSubprovider', () => { ledgerSubprovider = new LedgerSubprovider({ networkId, ledgerEthereumClientFactoryAsync: ledgerEthereumNodeJsClientFactoryAsync, - derivationPath: TESTRPC_DERIVATION_PATH, + derivationPath: fixtureData.TESTRPC_DERIVATION_PATH, }); }); describe('direct method calls', () => { @@ -46,7 +44,7 @@ describe('LedgerSubprovider', () => { }); it('returns the expected first account from a ledger set up with the test mnemonic', async () => { const accounts = await ledgerSubprovider.getAccountsAsync(); - expect(accounts[0]).to.be.equal(TEST_RPC_ACCOUNT_0); + expect(accounts[0]).to.be.equal(fixtureData.TEST_RPC_ACCOUNT_0); }); it('returns requested number of accounts', async () => { const numberOfAccounts = 20; @@ -55,12 +53,10 @@ describe('LedgerSubprovider', () => { expect(accounts.length).to.be.equal(numberOfAccounts); }); it('signs a personal message', async () => { - const data = ethUtils.bufferToHex(ethUtils.toBuffer('hello world')); + const data = ethUtils.bufferToHex(ethUtils.toBuffer(fixtureData.PERSONAL_MESSAGE_STRING)); const ecSignatureHex = await ledgerSubprovider.signPersonalMessageAsync(data); expect(ecSignatureHex.length).to.be.equal(132); - expect(ecSignatureHex).to.be.equal( - '0x1b0ec5e2908e993d0c8ab6b46da46be2688fdf03c7ea6686075de37392e50a7d7fcc531446699132fbda915bd989882e0064d417018773a315fb8d43ed063c9b00', - ); + expect(ecSignatureHex).to.be.equal(fixtureData.PERSONAL_MESSAGE_SIGNED_RESULT); }); it('signs a transaction', async () => { const tx = { @@ -69,7 +65,7 @@ describe('LedgerSubprovider', () => { to: '0x0000000000000000000000000000000000000000', value: '0x00', chainId: 3, - from: TEST_RPC_ACCOUNT_0, + from: fixtureData.TEST_RPC_ACCOUNT_0, }; const txHex = await ledgerSubprovider.signTransactionAsync(tx); expect(txHex).to.be.equal( @@ -173,7 +169,7 @@ describe('LedgerSubprovider', () => { // Give first account on Ledger sufficient ETH to complete tx send let tx = { to: accounts[0], - from: TEST_RPC_ACCOUNT_0, + from: fixtureData.TEST_RPC_ACCOUNT_0, value: '0x8ac7230489e80000', // 10 ETH }; let payload = { |