aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
diff options
context:
space:
mode:
authorAmir Bandeali <abandeali1@gmail.com>2018-07-06 05:31:55 +0800
committerAmir Bandeali <abandeali1@gmail.com>2018-07-07 04:23:09 +0800
commit07c111d1f589bab6ee573cfcbab891bd7b81dfc5 (patch)
tree82cbf0cc85486f773dd19c1279a795ac06ea7572 /packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
parenta2024da955ca63d3084a75927f4f1999e16bc849 (diff)
downloaddexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.tar
dexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.tar.gz
dexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.tar.bz2
dexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.tar.lz
dexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.tar.xz
dexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.tar.zst
dexon-0x-contracts-07c111d1f589bab6ee573cfcbab891bd7b81dfc5.zip
Remove TODOs that won't be addressed
Diffstat (limited to 'packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol')
-rw-r--r--packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol8
1 files changed, 3 insertions, 5 deletions
diff --git a/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol b/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
index cf53c3176..ec84b1e19 100644
--- a/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
+++ b/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
@@ -374,21 +374,19 @@ contract MixinExchangeCore is
returns (FillResults memory fillResults)
{
// Compute proportional transfer amounts
- // TODO: All three are multiplied by the same fraction. This can
- // potentially be optimized.
fillResults.takerAssetFilledAmount = takerAssetFilledAmount;
fillResults.makerAssetFilledAmount = getPartialAmount(
- fillResults.takerAssetFilledAmount,
+ takerAssetFilledAmount,
order.takerAssetAmount,
order.makerAssetAmount
);
fillResults.makerFeePaid = getPartialAmount(
- fillResults.takerAssetFilledAmount,
+ takerAssetFilledAmount,
order.takerAssetAmount,
order.makerFee
);
fillResults.takerFeePaid = getPartialAmount(
- fillResults.takerAssetFilledAmount,
+ takerAssetFilledAmount,
order.takerAssetAmount,
order.takerFee
);